Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port : Add Notification For BOM_VALIDATION_FAILED #839

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Port : Add Notification For BOM_VALIDATION_FAILED #839

merged 6 commits into from
Aug 13, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Aug 8, 2024 •
edited
Loading

Description

If uploaded BOM is invalid, dispatches a notification with InvalidBomProblemDetails before throwing the respective exception

Addressed Issue

Backport change : DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base enhancement New feature or request labels Aug 8, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Aug 8, 2024
@sahibamittal sahibamittal mentioned this pull request Aug 8, 2024
Merged
2 tasks
@sahibamittal sahibamittal mentioned this pull request Aug 12, 2024
Open
2 tasks
@sahibamittal sahibamittal marked this pull request as ready for review August 12, 2024 13:31
@codacy-production Codacy Production
Copy link

codacy-production bot commented Aug 12, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.05% (target: -1.00%) ✅ 94.74% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (af1d2de) 21118 17378 82.29%
Head commit (8e66ff3) 21159 (+41) 17423 (+45) 82.34% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#839) 38 36 94.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 1386be8 into main Aug 13, 2024
9 checks passed
@nscuro nscuro deleted the port-Add-Notification-For-BOM_VALIDATION_FAILED branch August 13, 2024 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sahibamittal @nscuro